Page 1 of 1

Carriage returns not present in later _cards.dat files

Posted: Sat Aug 13, 2016 12:14 pm
by GPBurdell
I'm running 0.20.1 right now. It seems like the _cards.dat for the latest-to-be-added sets do not have carriage returns in them. This causes Wagic to crash whenever you add a card from these sets (like Bloodbraid Elf or JTMS from the EMA set) to a deck and attempt to play the deck, or when you add the card from collection view, then switch to deck view.

The easy but tedious fix is to add carriage returns by hand. I think I have confirmed this because I added proper carriage returns with Bloodbraid Elf, added it to a deck, and played a match with that deck (casting BBE once). Everything worked.

Re: Carriage returns not present in later _cards.dat files

Posted: Sat Aug 13, 2016 2:54 pm
by kevlahnota
GPBurdell wrote:I'm running 0.20.1 right now. It seems like the _cards.dat for the latest-to-be-added sets do not have carriage returns in them. This causes Wagic to crash whenever you add a card from these sets (like Bloodbraid Elf or JTMS from the EMA set) to a deck and attempt to play the deck, or when you add the card from collection view, then switch to deck view.

The easy but tedious fix is to add carriage returns by hand. I think I have confirmed this because I added proper carriage returns with Bloodbraid Elf, added it to a deck, and played a match with that deck (casting BBE once). Everything worked.
Which sets? I can do it programmatically. Just give me the set names :)

Re: Carriage returns not present in later _cards.dat files

Posted: Sat Aug 13, 2016 7:05 pm
by GPBurdell
It looks like every set that was added to Wagic starting from Theros onward. The .dat for Dragon's Maze is fine, and then Theros begins the lack of carriage returns.

Re: Carriage returns not present in later _cards.dat files

Posted: Sat Aug 13, 2016 11:39 pm
by kevlahnota
GPBurdell wrote:It looks like every set that was added to Wagic starting from Theros onward. The .dat for Dragon's Maze is fine, and then Theros begins the lack of carriage returns.
Thanks, I just recheck them and it turns out that BFZ, OGW & SOI needs carriage returns. It's fixed on latest-git.
Theros set is fine:
Image

Re: Carriage returns not present in later _cards.dat files

Posted: Sun Aug 14, 2016 12:45 am
by GPBurdell
I must be getting the files from the wrong place on git-hub. I go to git, then I click on Code, then Releases. Is that the wrong path to take? When I download from the "latest-master", none of the latest sets have carriage returns. Can you link the latest? (Sorry, I have no idea how git-hub releases work)

Re: Carriage returns not present in later _cards.dat files

Posted: Sun Aug 14, 2016 12:57 am
by kevlahnota

Re: Carriage returns not present in later _cards.dat files

Posted: Sun Aug 14, 2016 1:06 am
by kevlahnota
GPBurdell wrote:I must be getting the files from the wrong place on git-hub. I go to git, then I click on Code, then Releases. Is that the wrong path to take? When I download from the "latest-master", none of the latest sets have carriage returns. Can you link the latest? (Sorry, I have no idea how git-hub releases work)
you're correct, the changes I made is not considered by github. i'll delete the files and upload the correct .dat