I need help with something simple (C)

[andfoy]

I'm coding in C an app for converting decimal numbers into binary ones, but i got a problem, when you input a letter the console freezes into an infinite loop, so what i can do? Here's the code:

Code: Select all

#include <stdio.h>
#include <stdlib.h>

int main(int argc, char **argv)
{
     int mask = 2147483648; 
     int numInput;

     printf:  Decimal a Binario (Convertir)

     do
    {
        printf ("\n\nIngresar un numero Decimal (o 999999 para salir): "); 
          scanf ("%d", &numInput);

        printf("\nEl equivalente en binario de (%d) es: \t", numInput);

    for (int i = 0; i < 32; i++)
    {

      if ((numInput & mask) == 0)
                {
                     printf("0");
             }

    else
               {
                    printf("1");
               }

    if (numInput == 999999 )
                    {
                        return(0);
                    }

    numInput = numInput << 1;

               }
        }

    while(1)

}

Advertising

[m0skit0]

Check what value numInput gets when you input a character and try to filter that.

Advertising

[andfoy]

All the characters returned 0 so can i do this?:

Code: Select all

if numInput=0
{ puts ("\n\n ERROR!\n");
  return (0);
}

[electrosheep]

Well, I think m0squit0 already nailed it, but imo, I think it would be best for you to figure out whats wrong on your own.
A few tips: your code seems fairly scattered about. If you need a good text editor, notepad ++ will help you organize your code so it's easier for other people to read.
If you honestly have no idea where to start, I'll help you: You have a loop whose terminating conditions are never met, so it never ends. It's fairly obvious what the problem is once you know what to look for.

EDIT: actually, your code is poorly written. For example, you have something like this:

Code: Select all

do{
     ...
     if (condition)
          return 0; // thus ending the loop
} while (1);

Why do that when you can simply do this:

Code: Select all

do{
     ...
} while (condition);

[andfoy]

Wow, thanks. Sorry i'm starting to learn C, so i use all

[electrosheep]

So did you get it figured out?