[CODE] Counter Improvements (Now Included in SVN)

[salmelo]

Here is another patch, this time adding counters to target specifications, so now you should be able to target things with counters on them as well as use counters for criterion for Lord, aslongas, foreach, etc.

I had to muddle the syntax a little bit though, so heres an example, taken from gwafa hazid, whom I added to the primitives to test with.

lord(creature[counter{0/0.1.Bribe}]|opponentbattlefield) cantattack

obviously the part we are worried about is the counter part, note that those are curly braces { } and periods . instead of parentheses ( ) and commas , this is so that it does not conflict with how targets are normally parsed, which it did before I changed those. Counters still work the same way everywhere else though, you only need to use { } and periods in target code.

Also, you can use counter{any} to specify that it should look for things with any kind of counter on them, not just specific ones, this is used by Kulrath Knight, for example.

I also consolidated most of the code used to parse counter specifications, as it seemed unnecessary duplicating it three times.

Anyway, aside from this major addition, I also added Gwafa Hazid, Profiteer; and Kulrath Knight to the primitives, as well as a test file for each to make sure it worked.

Hopefully y'all will find this patch useful.

Oh, and I should point out that it only works with one Counter in the target specification, i imagine if you put two in the same one then it would either overwrite the first with the second or merge them into some sort of hybrid counter monstrosity, either way, I wouldn't suggest it.

EDIT: attachment removed in favor of updated version a few posts down.

[Dr.Solomat]

1. Can anyone add this to the svn plz??

2. Can the counter number be 0? This would be interesting for cards with "Fading","Vanishing",etc....

Is this card now possible??




codeline would be:

auto=@each my firstmain:foreach(counter{0/0.Charge}) add{B}

Will this work??

[salmelo]

well, I can't actually see the picture of the card right now as wherever its hosted is blocked by my current locations webserver, but from the code line I'm guessing you want it to add B to mana pool for each charge counter on the card?

If so, then no, that is not currently possible, the same goes for vanishing and fading, if I remember them correctly.

This is because there is still no way to say "for every counter on this card". what foreach(creature[counter{0/0.1.Charge}]) would do is happen once for every creature in play that had at least one charge counter on it.

I will be working on something like what you were thinking of as my next priority, i think.

[Dr.Solomat]

vanishing code lines would be like:

[card]
name=Aven Riftwatcher
abilities=flying
auto=counter(0/0,3,Time)
auto=life:2
auto=@movedTo(this|exile,graveyard,hand,library) from(myBattlefield):life:2
auto=@each my upkeep:counter(0/0,-1,Time)
auto=lord(aven riftwatcher[counter{0/0.0.Time}]|myBattlefield) -99/-99
text=Flying -- Vanishing 3 (This permanent enters the battlefield with three time counters on it. At the beginning of your upkeep, remove a time counter from it. When the last is removed, sacrifice it.) -- When Aven Riftwatcher enters the battlefield or leaves the battlefield, you gain 2 life.
mana={2}{W}
type=Creature
subtype=Bird rebel Soldier
power=2
toughness=3
[/card]

[salmelo]

ah, that way might work.

i would do it this way:
auto=lord(aven riftwatcher[-counter{0/0.1.Time}]|myBattlefield) -99/-99

this is because it normally checks if the card has At Least that many counters, but with a minus sign it does Less Than that many counters, something I probably should have mentioned when i posted the patch...

so that line would kill it when the number of Time counters on it was < 1, essentially, when it hit 0.

Of course, the code is still flawed because it's technically supposed to be a sacrifice, but since I don't think we have things triggering off of sacrifices yet, thats not a big deal.

[Dr.Solomat]

i would do it this way:
auto=lord(aven riftwatcher[-counter{0/0.1.Time}]|myBattlefield) -99/-99

this is because it normally checks if the card has At Least that many counters, but with a minus sign it does Less Than that many counters, something I probably should have mentioned when i posted the patch...

so that line would kill it when the number of Time counters on it was < 1, essentially, when it hit 0.

Are you sure this works? Did you test that? This would be great!


EDIT: The problem I see hear is that not with such an autoline even those Blastoderms get killed which don't have EXACTLY 1 fade counter on them, this means even those with 2 or more fade counters...

[salmelo]

Are you sure this works? Did you test that? This would be great!

well, i just tested it and no, it does not work, but I think I know why, and I'm going to fix and upload an updated patch.

[Dr.Solomat]

You are the best, man!

[salmelo]

You are the best, man!

Thanks

anyway, heres the updated patch, it also adds aven riftwatcher to the primitives and a couple testfiles that make sure vanishing works.

[Dr.Solomat]

what is Aven Riftwatcher's code? Can you post it here?